Re: [PATCH] nvme: duplicate NQNs check if devices needed

[Chaitanya Kulkarni]

Liguang,

On 11/29/21 8:34 AM, Keith Busch wrote:
> On Mon, Nov 29, 2021 at 07:18:54PM +0800, Liguang Zhang wrote:
>> @@ -2587,6 +2587,9 @@ static struct nvme_subsystem *__nvme_find_get_subsystem(const char *subsysnqn)
>>   
>>   	lockdep_assert_held(&nvme_subsystems_lock);
>>   
>> +	if (strncmp(subsysnqn, "nqn.", 4))
>> +		return NULL;
> 
> This seems like an arbitrary way to decide not to check for duplicates.
> Shouldn't we just add the NVME_QUIRK_IGNORE_DEV_SUBNQN quirk for the
> broken controllers?
> 

Please add t he quirk for a specific controller(s) as mentioned
by Keith.

-ck