Re: [PATCH 1/3] selftests/resctrl: Make resctrl_tests run using kselftest framework

From: Reinette Chatre
Date: Mon Nov 29 2021 - 14:31:08 EST


Hi Shaopeng Tan,

On 11/10/2021 1:33 AM, Shaopeng Tan wrote:
From: "Tan, Shaopeng" <tan.shaopeng@xxxxxxxxxxxxxx>

This commit enables kselftest to be built/run in resctrl framework.
Build/run resctrl_tests by build/run all tests of kselftest, or by using
the "TARGETS" variable on the make command line to specify resctrl_tests.
To make resctrl_tests run using kselftest framework, this commit modified
the Makefile of kernel kselftest set and the Makefile of resctrl_tests.

The above sentence mentions that changes were made to the resctrl selftest Makefile but it does not describe what the change accomplish or why they are needed. Could you please elaborate?

To ensure the resctrl_tests finish in limited time, this commit changed
the default limited time(45s) to 120 seconds for resctrl_tests by adding
"setting" file.

How is changing the timeout related to the resctrl framework changes? Is it not a separate change?

Thank you

Reinette