Re: [PATCH] ASoC: Intel: atom: Remove redundant check to simplify the code

From: Mark Brown
Date: Mon Nov 29 2021 - 15:37:49 EST


On Mon, Nov 29, 2021 at 10:22:41AM -0600, Pierre-Louis Bossart wrote:
> On 11/25/21 1:50 AM, Tang Bin wrote:

> > In the function sst_platform_get_resources(), if platform_get_irq()
> > failed, the return should not be zero, as the example in
> > platform.c is
> > * int irq = platform_get_irq(pdev, 0)
> > * if (irq < 0)
> > * return irq;
> > So remove the redundant check to simplify the code.

> Humm, it's a bit of a gray area.

> the comments for platform_get_irq and platform_get_irq_optional say:

> * Return: non-zero IRQ number on success, negative error number on failure.

> but if you look at platform_get_irq_optional, there are two references
> to zero being a possible return value:

Zero is (or was, people were working on changing it partly due to
confusion and partly due to moving to newer infrastructure which
doesn't use it) a valid IRQ on some architectures. x86 wasn't one of
those though, at least AFAIR.

Attachment: signature.asc
Description: PGP signature