Re: [PATCH v3 10/10] dt-bindings: convert qcom,spmi-pmic-arb binding to YAML format

[Fenglin Wu]

On 2021/11/29 23:30, Rob Herring wrote:
> On Mon, 29 Nov 2021 16:22:17 +0800, Fenglin Wu wrote:
> > Convert the SPMI PMIC arbiter documentation to JSON/yaml. While at it,
> > update SPMI bus "reg" items constraint for SPMI PMIC arbiter to carry
> > it and update it with a smaller range.
> >
> > Signed-off-by: Fenglin Wu <quic_fenglinw@xxxxxxxxxxx>
> > ---
> >   .../bindings/spmi/qcom,spmi-pmic-arb.txt           |  67 -----------
> >   .../bindings/spmi/qcom,spmi-pmic-arb.yaml          | 128 +++++++++++++++++++++
> >   Documentation/devicetree/bindings/spmi/spmi.yaml   |   3 +-
> >   3 files changed, 130 insertions(+), 68 deletions(-)
> >   delete mode 100644 Documentation/devicetree/bindings/spmi/qcom,spmi-pmic-arb.txt
> >   create mode 100644 Documentation/devicetree/bindings/spmi/qcom,spmi-pmic-arb.yaml
> My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
> on your patch (DT_CHECKER_FLAGS is new in v5.13):
>
> yamllint warnings/errors:
> ./Documentation/devicetree/bindings/spmi/qcom,spmi-pmic-arb.yaml:37:9: [warning] wrong indentation: expected 10 but found 8 (indentation)
> ./Documentation/devicetree/bindings/spmi/qcom,spmi-pmic-arb.yaml:41:9: [warning] wrong indentation: expected 10 but found 8 (indentation)
I will fix the indentation warning in next patch. I double checked this
at my side but it's curious that it didn't show up at my side even I have
installed yamllint and also upgraded dtschema to the latest.
> dtschema/dtc warnings/errors:
>
> doc reference errors (make refcheckdocs):
> Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.txt: Documentation/devicetree/bindings/spmi/qcom,spmi-pmic-arb.txt
>
> See https://patchwork.ozlabs.org/patch/1561055
>
> This check can fail if there are any dependencies. The base for a patch
> series is generally the most recent rc1.
>
> If you already ran 'make dt_binding_check' and didn't see the above
> error(s), then make sure 'yamllint' is installed and dt-schema is up to
> date:
>
> pip3 install dtschema --upgrade
>
> Please check and re-submit.