Re: [PATCH v2 2/2] scsi: qedi: Fix SYSFS_FLAG_FW_SEL_BOOT formatting

[Florian Fainelli]

On 11/29/2021 7:59 PM, Martin K. Petersen wrote:
> Florian,
>
> > The format used for formatting SYSFS_FLAG_FW_SEL_BOOT creates the
> > following warning:
> >
> > drivers/scsi/qedi/qedi_main.c:2259:35: warning: format specifies type
> > 'char' but the argument has type 'int' [-Wformat]
> >                     rc = snprintf(buf, 3, "%hhd\n",
> > SYSFS_FLAG_FW_SEL_BOOT);
> >
> > Fix this to cast the constant as an u8 since the intention is to print
> > it via sysfs as a byte.
>
> The other occurrences of SYSFS_FLAG_FW_SEL_BOOT use "%d". Since %hh is
> deprecated I suggest you just fix the snprintf().

That was what v1 did here:

https://lkml.org/lkml/2021/11/26/9

however Manish seemed to want that flag to be printed as a byte I am 
fine either way.
--
Florian