Re: [PATCH net-next v1] devlink: Simplify devlink resources unregister call

[Jakub Kicinski]

On Tue, 30 Nov 2021 10:00:28 +0200 Leon Romanovsky wrote:
> > Hiding struct devlink_resource is not mentioned in the commit message
> > and entirely unrelated to removal of the unused argument.  
> 
> devlink_resources_unregister() was the API function that is declared in
> the devlink.h that used "struct devlink_resource". Once we removed extra
> parameter from that function, the "struct devlink_resource" left as not
> used at all. So this "hiding" is related and part of this simplification
> patch.
> 
> I will add it to the commit message.

Forward declarations exist. The author did not have to disclose the
definition of the structure. Removing this definition is not related,
you just like doing it.