Re: [PATCH v1] perf trace: Enable ignore_missing_thread for trace

From: Arnaldo Carvalho de Melo
Date: Tue Nov 30 2021 - 10:18:28 EST


Em Tue, Nov 23, 2021 at 03:40:17PM +0800, Gang Li escreveu:
> perf already support ignore_missing_thread for -u/-p, but not yet
> applied to `perf trace`. This patch enable ignore_missing_thread
> for `perf trace`.
>
> ref:
> Link: http://lkml.kernel.org/r/1481538943-21874-6-git-send-email-jolsa@xxxxxxxxxx
> Link: http://lkml.kernel.org/r/1513148513-6974-1-git-send-email-zhangmengting@xxxxxxxxxx
> Signed-off-by: Gang Li <ligang.bdlg@xxxxxxxxxxxxx>
> ---
> tools/perf/builtin-trace.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/tools/perf/builtin-trace.c b/tools/perf/builtin-trace.c
> index 0b52e08e558e..94d62a92f1a1 100644
> --- a/tools/perf/builtin-trace.c
> +++ b/tools/perf/builtin-trace.c
> @@ -3950,6 +3950,9 @@ static int trace__run(struct trace *trace, int argc, const char **argv)
> evlist__add(evlist, pgfault_min);
> }
>
> + /* Enable ignoring missing threads when -u/-p option is defined. */
> + trace->opts.ignore_missing_thread = trace->opts.target.uid != UINT_MAX || trace->opts.target.pid;
> +
> if (trace->sched &&
> evlist__add_newtp(evlist, "sched", "sched_stat_runtime", trace__sched_stat_runtime))
> goto out_error_sched_stat_runtime;

Thanks, applied.

- Arnaldo