Re: [PATCH 07/21] ASoC: amd: Add module to determine ACP configuration

From: Pierre-Louis Bossart
Date: Tue Nov 30 2021 - 11:49:50 EST





>> --- a/sound/soc/amd/Kconfig
>> +++ b/sound/soc/amd/Kconfig
>> @@ -96,4 +96,10 @@ config SND_SOC_AMD_YC_MACH
>> Say m if you have such a device.
>> If unsure select "N".
>>
>> +config SND_AMD_ACP_CONFIG
>> + tristate "AMD ACP configuration selection"
>
> This definitely needs proper dependencies, to prevent asking the user
> about this when configuring a kernel without AMD Audio ACP support.
>
> I would have sent a patch, but...

There's indeed a missing dependency that was fixed in
https://github.com/thesofproject/linux/pull/3284

Daniel, you may want to squash it in an update?

To Geert's point, there may be an additional need to add a

depends on SND_SOC_AMD_ACP

There are also a set of

SND_SOC_AMD_ACPyx options, not sure if any applies as a dependency here?