Re: [patch 05/22] genirq/msi: Fixup includes

[Cédric Le Goater]

On 11/29/21 22:38, Thomas Gleixner wrote:
> Cedric,
>
> On Mon, Nov 29 2021 at 08:33, Cédric Le Goater wrote:
> > On 11/27/21 02:18, Thomas Gleixner wrote:
> > > Remove the kobject.h include from msi.h as it's not required and add a
> > > sysfs.h include to the core code instead.
> > >
> > > Signed-off-by: Thomas Gleixner <tglx@xxxxxxxxxxxxx>
> >
> >
> > This patch breaks compile on powerpc :
> >
> >     CC      arch/powerpc/kernel/msi.o
> > In file included from ../arch/powerpc/kernel/msi.c:7:
> > ../include/linux/msi.h:410:65: error: ‘struct cpumask’ declared inside parameter list will not be visible outside of this definition or declaration [-Werror]
> >     410 | int msi_domain_set_affinity(struct irq_data *data, const struct cpumask *mask,
> >         |                                                                 ^~~~~~~
> > cc1: all warnings being treated as errors
> >
> > Below is fix you can merge in patch 5.
>
> thanks for having a look. I fixed up this and other fallout and pushed out an
> updated series (all 4 parts) to:
>
>          git://git.kernel.org/pub/scm/linux/kernel/git/tglx/devel msi

pSeries fails to allocate MSIs starting with this patch :

 [PATCH 049/101] powerpc/pseries/msi: Let core code check for contiguous ...

I will dig in later on.

C.