RE: [Intel-wired-lan] [PATCH v4 net-next 5/9] ice: respect metadata on XSK Rx to skb

[Bhandare, KiranX]

> -----Original Message-----
> From: Intel-wired-lan <intel-wired-lan-bounces@xxxxxxxxxx> On Behalf Of
> Alexander Lobakin
> Sent: Wednesday, December 8, 2021 7:37 PM
> To: intel-wired-lan@xxxxxxxxxxxxxxxx
> Cc: Song Liu <songliubraving@xxxxxx>; Alexei Starovoitov <ast@xxxxxxxxxx>;
> Andrii Nakryiko <andrii@xxxxxxxxxx>; Daniel Borkmann
> <daniel@xxxxxxxxxxxxx>; John Fastabend <john.fastabend@xxxxxxxxx>;
> Jesper Dangaard Brouer <brouer@xxxxxxxxxx>; Yonghong Song
> <yhs@xxxxxx>; Jesper Dangaard Brouer <hawk@xxxxxxxxxx>; KP Singh
> <kpsingh@xxxxxxxxxx>; Jakub Kicinski <kuba@xxxxxxxxxx>;
> netdev@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; David S. Miller
> <davem@xxxxxxxxxxxxx>; Björn Töpel <bjorn@xxxxxxxxxx>;
> bpf@xxxxxxxxxxxxxxx; Martin KaFai Lau <kafai@xxxxxx>
> Subject: [Intel-wired-lan] [PATCH v4 net-next 5/9] ice: respect metadata on
> XSK Rx to skb
> 
> For now, if the XDP prog returns XDP_PASS on XSK, the metadata will be lost
> as it doesn't get copied to the skb.
> Copy it along with the frame headers. Account its size on skb allocation, and
> when copying just treat it as a part of the frame and do a pull after to "move"
> it to the "reserved" zone.
> net_prefetch() xdp->data_meta and align the copy size to speed-up
> memcpy() a little and better match ice_costruct_skb().
> 
> Fixes: 2d4238f55697 ("ice: Add support for AF_XDP")
> Suggested-by: Jesper Dangaard Brouer <brouer@xxxxxxxxxx>
> Suggested-by: Maciej Fijalkowski <maciej.fijalkowski@xxxxxxxxx>
> Signed-off-by: Alexander Lobakin <alexandr.lobakin@xxxxxxxxx>
> Reviewed-by: Michal Swiatkowski <michal.swiatkowski@xxxxxxxxxxxxxxx>
> ---
>  drivers/net/ethernet/intel/ice/ice_xsk.c | 14 ++++++++++----
>  1 file changed, 10 insertions(+), 4 deletions(-)
> 

Tested-by: Kiran Bhandare <kiranx.bhandare@xxxxxxxxx>  A Contingent Worker at Intel