Re: [PATCH v7 3/4] clk: ralink: make system controller node a reset provider

[Philipp Zabel]

On Mon, 2022-01-10 at 12:10 +0100, Sergio Paracuellos wrote:
[...]
> +static int mt7621_rst_xlate(struct reset_controller_dev *rcdev,
> +			    const struct of_phandle_args *reset_spec)
> +{
> +	unsigned long id = reset_spec->args[0];
> +
> +	if (id == MT7621_RST_SYS)

	if (id == MT7621_RST_SYS || id >= rcdev->nr_resets)

I forgot to mention that with .of_xlate set, the driver needs to check
whether id < nr_resets on its own.

regards
Philipp