RE: [PATCH v2] scsi: ufs: modify Tactive time setting conditions

[Alim Akhtar]

Hello Seo Hoyoung,

>-----Original Message-----
>From: SEO HOYOUNG [mailto:hy50.seo@xxxxxxxxxxx]
>Sent: Friday, January 7, 2022 3:09 AM
>To: linux-scsi@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx;
>alim.akhtar@xxxxxxxxxxx; avri.altman@xxxxxxx; jejb@xxxxxxxxxxxxx;
>martin.petersen@xxxxxxxxxx; beanhuo@xxxxxxxxxx;
>asutoshd@xxxxxxxxxxxxxx; cang@xxxxxxxxxxxxxx; bvanassche@xxxxxxx
>Cc: SEO HOYOUNG <hy50.seo@xxxxxxxxxxx>
>Subject: [PATCH v2] scsi: ufs: modify Tactive time setting conditions
>
>The Tactive time determine the waiting time before burst at hibern8 exit and
>is determined by H/W at linkup state However, in the case of samsung
>devices, guided host's Tactive time
>+100us for stability.
>If the HCI's Tactive time is equal or greater than the device,
>+100us should be set.
>
>Signed-off-by: SEO HOYOUNG <hy50.seo@xxxxxxxxxxx>
>---
Thanks!
Reviewed-by: Alim Akhtar <alim.akhtar@xxxxxxxxxxx>

> drivers/scsi/ufs/ufshcd.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c index
>1049e41abd5b..460d2b440d2e 100644
>--- a/drivers/scsi/ufs/ufshcd.c
>+++ b/drivers/scsi/ufs/ufshcd.c
>@@ -7815,7 +7815,7 @@ static int
>ufshcd_quirk_tune_host_pa_tactivate(struct ufs_hba *hba)
> 	peer_pa_tactivate_us = peer_pa_tactivate *
> 			     gran_to_us_table[peer_granularity - 1];
>
>-	if (pa_tactivate_us > peer_pa_tactivate_us) {
>+	if (pa_tactivate_us >= peer_pa_tactivate_us) {
> 		u32 new_peer_pa_tactivate;
>
> 		new_peer_pa_tactivate = pa_tactivate_us /
>--
>2.26.0