Re: Re: [PATCH] media: vidtv: Check for null return of vzalloc

From: Jiasheng Jiang
Date: Tue Jan 11 2022 - 21:07:47 EST


On Tue, Jan 11, 2022 at 05:58:10PM +0800, Hans Verkuil wrote:
> This doesn't free e->name!
>
> Actually, the same issue is also present later in this function:
>
> ctx = kzalloc(priv_sz, GFP_KERNEL);
> if (!ctx) {
> kfree(e);
> return NULL;
> }

>> + kfree(e);
>> + return NULL;
>> + }

Thanks for your reminder.
I have sent a v2 to fix it.
And also I have sent a patch to fix the 'ctx' with
'Reported-by: Hans Verkuil <hverkuil@xxxxxxxxx>',
since they are two different things.

Sincerely thanks,
Jiang