Re: [PATCH] media: vidtv: Check for null return of vzalloc

[Hans Verkuil]

On 12/01/2022 03:07, Jiasheng Jiang wrote:
> On Tue, Jan 11, 2022 at 05:58:10PM +0800, Hans Verkuil wrote:
>> This doesn't free e->name!
>>
>> Actually, the same issue is also present later in this function:
>>
>> ctx = kzalloc(priv_sz, GFP_KERNEL);
>>        if (!ctx) {
>> 	        kfree(e);
>> 	        return NULL;
>> 	}
> 
>>> +		kfree(e);
>>> +		return NULL;
>>> +	}
> 
> Thanks for your reminder.
> I have sent a v2 to fix it.
> And also I have sent a patch to fix the 'ctx' with
> 'Reported-by: Hans Verkuil <hverkuil@xxxxxxxxx>',
> since they are two different things.

Actually no. It's all the same thing: not correctly freeing allocated memory
in a function.

Please combine it all in a single patch.

Perhaps this should use the 'goto' method of cleaning up after errors instead
of duplicating kfree()s in two places. A bit borderline what works best here.

Regards,

	Hans

> 
> Sincerely thanks,
> Jiang
>