Re: [PATCH] ath11k: fix error handling in ath11k_qmi_assign_target_mem_chunk()

From: Kalle Valo
Date: Mon Jan 17 2022 - 08:00:35 EST


trix@xxxxxxxxxx wrote:

> From: Tom Rix <trix@xxxxxxxxxx>
>
> Clang static analysis reports this problem
> qmi.c:1935:5: warning: Undefined or garbage value returned to caller
> return ret;
> ^~~~~~~~~~
>
> ret is uninitialized. When of_parse_phandle() fails, garbage is
> returned. So return -EINVAL.
>
> Fixes: 6ac04bdc5edb ("ath11k: Use reserved host DDR addresses from DT for PCI devices")
> Signed-off-by: Tom Rix <trix@xxxxxxxxxx>

I just applied a fix from Dan:

https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/ath.git/commit/?h=ath-next&id=c9b41832dc08

Patch set to Superseded.

--
https://patchwork.kernel.org/project/linux-wireless/patch/20220116144206.399385-1-trix@xxxxxxxxxx/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches