Re: [PATCH 3/3] nvmem: core: Fix a conflict between MTD and NVMEM on wp-gpios property
From: Srinivas Kandagatla
Date: Tue Jan 25 2022 - 05:49:13 EST
On 05/01/2022 13:57, Christophe Kerello wrote:
diff --git a/drivers/nvmem/core.c b/drivers/nvmem/core.c
index e765d3d0542e..e11c74db64f9 100644
--- a/drivers/nvmem/core.c
+++ b/drivers/nvmem/core.c
@@ -769,7 +769,7 @@ struct nvmem_device *nvmem_register(const struct nvmem_config *config)
if (config->wp_gpio)
nvmem->wp_gpio = config->wp_gpio;
- else
+ else if (config->reg_write)
This is clearly not going to work for everyone.
A flag in nvmem_config to indicate that wp gpio is managed by provider
driver would be the right thing to do here.
nvmem->wp_gpio = gpiod_get_optional(config->dev, "wp",
GPIOD_OUT_HIGH);
--srini