Re: [PATCH 3/3] nvmem: core: Fix a conflict between MTD and NVMEM on wp-gpios property

[Christophe Kerello]

Hi Srinivas, Miquel,

On 1/25/22 11:44, Srinivas Kandagatla wrote:
> On 05/01/2022 13:57, Christophe Kerello wrote:
> > diff --git a/drivers/nvmem/core.c b/drivers/nvmem/core.c
> > index e765d3d0542e..e11c74db64f9 100644
> > --- a/drivers/nvmem/core.c
> > +++ b/drivers/nvmem/core.c
> > @@ -769,7 +769,7 @@ struct nvmem_device *nvmem_register(const struct 
> > nvmem_config *config)
> >       if (config->wp_gpio)
> >           nvmem->wp_gpio = config->wp_gpio;
> > -    else
> > +    else if (config->reg_write)
> This is clearly not going to work for everyone.
>
> A flag in nvmem_config to indicate that wp gpio is managed by provider 
> driver would be the right thing to do here.

Based on your inputs, I will add a new boolean flag in nvmen_config 
(proposal name: skip_wp_gpio) and I will set it to true in mtdcore.c 
when nvmen_config structure is initialized. It will be part of the V2.

Regards,
Christophe Kerello.

> >           nvmem->wp_gpio = gpiod_get_optional(config->dev, "wp",
> >                               GPIOD_OUT_HIGH);
>
> --srini