Re: [v5 PATCH] block: introduce block_rq_error tracepoint

[Christoph Hellwig]

On Wed, Jan 26, 2022 at 10:51:53AM -0800, Yang Shi wrote:
> +		__entry->dev	   = rq->q->disk ? disk_devt(rq->q->disk) : 0;
> +		__assign_str(name,   rq->q->disk ? rq->q->disk->disk_name : "?");

None f the other tracepoints has the disk name, why does this one need
it?  And if you add it please avoid the overly long line.

> +		__entry->sector    = blk_rq_pos(rq);
> +		__entry->nr_sector = nr_bytes >> 9;
> +		__entry->error     = blk_status_to_errno(error);

This still converts the block status to an errno.