Re: [PATCH] nvme: Fix missing error code in nvme_configure_directives()

From: Keith Busch
Date: Mon Feb 14 2022 - 22:56:47 EST


On Tue, Feb 15, 2022 at 11:36:32AM +0800, Jiapeng Chong wrote:
> The error code is missing in this code scenario, add the error code
> '-EINVAL' to the return value 'ret'.
>
> Eliminate the follow smatch warning:
>
> drivers/nvme/host/core.c:780 nvme_configure_directives() warn: missing
> error code 'ret'.

Nak, the code is correct as-is, just like it was the previous time you
posted this patch:

http://lists.infradead.org/pipermail/linux-nvme/2021-September/027339.html