Re: [PATCH] nvme: Fix missing error code in nvme_configure_directives()

[Christophe JAILLET]

Le 15/02/2022 à 04:55, Keith Busch a écrit :
> On Tue, Feb 15, 2022 at 11:36:32AM +0800, Jiapeng Chong wrote:
> > The error code is missing in this code scenario, add the error code
> > '-EINVAL' to the return value 'ret'.
> >
> > Eliminate the follow smatch warning:
> >
> > drivers/nvme/host/core.c:780 nvme_configure_directives() warn: missing
> > error code 'ret'.
>
> Nak, the code is correct as-is, just like it was the previous time you
> posted this patch:
>
>    http://lists.infradead.org/pipermail/linux-nvme/2021-September/027339.html

Hi,

maybe an explicit 'ret = 0;' (and eventually a comment saying why) would 
help here?

The code really looks like an error handling path (and will keep getting 
some patches for it because of bots).

Just my 2c.

CJ