Re: [PATCH] usb: xhci: make XHCI_STOP_EP_CMD_TIMEOUT a module parameter
From: Greg KH
Date: Fri Mar 04 2022 - 09:17:28 EST
On Fri, Mar 04, 2022 at 12:30:57PM +0100, Martin Kepplinger wrote:
> On the Librem 5 imx8mq system we've seen the stop endpoint command
> time out regularly which results in the hub dying.
>
> While on the one hand we see "Port resume timed out, port 1-1: 0xfe3"
> before this and on the other hand driver-comments suggest that the driver
> might be able to recover instead of dying here, Sarah seemed to have a
> workaround for this particulator problem in mind already:
>
> Make it a module parameter. So while it might not be the root cause for
> the problem, do this to give users a workaround.
This is not the 1990's, sorry, please do not add new module parameters.
They modify code, when you want to modify an individual device.
thanks,
greg k-h