Re: [PATCH] isdn: hfcpci: check the return value of dma_set_mask() in setup_hw()

From: Jia-Ju Bai
Date: Sat Mar 05 2022 - 03:35:40 EST




On 2022/3/4 13:15, Jakub Kicinski wrote:
On Wed, 2 Mar 2022 18:57:10 -0800 Jia-Ju Bai wrote:
The function dma_set_mask() in setup_hw() can fail, so its return value
should be checked.

Fixes: e85da794f658 ("mISDN: switch from 'pci_' to 'dma_' API")
The change under Fixes only switched the helper the driver uses,
it did not introduce the problem. The Fixes tag should point to
the earliest commit where the problem is present.

Hi Jakub,

Thanks for the advice.
I will send a V2 patch.


Best wishes,
Jia-Ju Bai