Re: [PATCH] net: qlogic: check the return value of dma_alloc_coherent() in qed_vf_hw_prepare()

From: Jia-Ju Bai
Date: Sat Mar 05 2022 - 03:37:41 EST




On 2022/3/4 13:19, Jakub Kicinski wrote:
On Wed, 2 Mar 2022 19:34:50 -0800 Jia-Ju Bai wrote:
--- a/drivers/net/ethernet/qlogic/qed/qed_vf.c
+++ b/drivers/net/ethernet/qlogic/qed/qed_vf.c
@@ -513,6 +513,9 @@ int qed_vf_hw_prepare(struct qed_hwfn *p_hwfn)
p_iov->bulletin.size,
&p_iov->bulletin.phys,
GFP_KERNEL);
+ if (!p_iov->bulletin.p_virt)
+ goto free_vf2pf_request;
leaking the reply buffer

Hi Jakub,

Thanks for pointing out this problem.
I will send a V2 patch.


Best wishes,
Jia-Ju Bai