[PATCH] ASoC: atmel: mchp-pdmc: Fix `-Wpointer-bool-conversion` warning

From: Alviro Iskandar Setiawan
Date: Wed Mar 09 2022 - 01:59:11 EST


In function mchp_pdmc_af_put(), Intel's kernel test robot reports the
following warning:

sound/soc/atmel/mchp-pdmc.c:186:34: warning: address of array \
'uvalue->value.integer.value' will always evaluate to 'true' \
[-Wpointer-bool-conversion]

This is because we are using `uvalue->value.integer.value` which its
type is `long value[128];` for conditional expression and that array
will always decay to a non-NULL pointer. Using a non-NULL pointer for
conditional expression will always evaluate to true.

Fix this by changing it to `uvalue->value.integer.value[0]` as that's
what the mchp_pdmc_af_get() function sets.

To: Mark Brown <broonie@xxxxxxxxxx>
Cc: Codrin Ciubotariu <codrin.ciubotariu@xxxxxxxxxxxxx>
Cc: Nugraha <richiisei@xxxxxxxxx>
Cc: llvm@xxxxxxxxxxxxxxx
Cc: kbuild-all@xxxxxxxxxxxx
Cc: gwml@xxxxxxxxxxxxxxxx
Cc: linux-kernel@xxxxxxxxxxxxxxx
Reported-by: kernel test robot <lkp@xxxxxxxxx>
Link: https://lore.kernel.org/lkml/202203091430.MLY27Bif-lkp@xxxxxxxxx
Fixes: 50291652af5269813baa6024eb0e81b5f0bbb451 ("ASoC: atmel: mchp-pdmc: add PDMC driver")
Signed-off-by: Alviro Iskandar Setiawan <alviro.iskandar@xxxxxxxxxxx>
---
sound/soc/atmel/mchp-pdmc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/sound/soc/atmel/mchp-pdmc.c b/sound/soc/atmel/mchp-pdmc.c
index c44636f6207d..7b87f75c284c 100644
--- a/sound/soc/atmel/mchp-pdmc.c
+++ b/sound/soc/atmel/mchp-pdmc.c
@@ -183,7 +183,7 @@ static int mchp_pdmc_af_put(struct snd_kcontrol *kcontrol,
{
struct snd_soc_component *component = snd_kcontrol_chip(kcontrol);
struct mchp_pdmc *dd = snd_soc_component_get_drvdata(component);
- bool af = uvalue->value.integer.value ? true : false;
+ bool af = uvalue->value.integer.value[0] ? true : false;

if (dd->audio_filter_en == af)
return 0;

base-commit: 50291652af5269813baa6024eb0e81b5f0bbb451
--
2.27.0