Re: [PATCH] ASoC: atmel: mchp-pdmc: Fix `-Wpointer-bool-conversion` warning

[Codrin.Ciubotariu]

On 09.03.2022 08:58, Alviro Iskandar Setiawan wrote:
> In function mchp_pdmc_af_put(), Intel's kernel test robot reports the
> following warning:
> 
>    sound/soc/atmel/mchp-pdmc.c:186:34: warning: address of array \
>    'uvalue->value.integer.value' will always evaluate to 'true' \
>    [-Wpointer-bool-conversion]
> 
> This is because we are using `uvalue->value.integer.value` which its
> type is `long value[128];` for conditional expression and that array
> will always decay to a non-NULL pointer. Using a non-NULL pointer for
> conditional expression will always evaluate to true.
> 
> Fix this by changing it to `uvalue->value.integer.value[0]` as that's
> what the mchp_pdmc_af_get() function sets.
> 
> To: Mark Brown <broonie@xxxxxxxxxx>
> Cc: Codrin Ciubotariu <codrin.ciubotariu@xxxxxxxxxxxxx>
> Cc: Nugraha <richiisei@xxxxxxxxx>
> Cc: llvm@xxxxxxxxxxxxxxx
> Cc: kbuild-all@xxxxxxxxxxxx
> Cc: gwml@xxxxxxxxxxxxxxxx
> Cc: linux-kernel@xxxxxxxxxxxxxxx
> Reported-by: kernel test robot <lkp@xxxxxxxxx>
> Link: https://lore.kernel.org/lkml/202203091430.MLY27Bif-lkp@xxxxxxxxx
> Fixes: 50291652af5269813baa6024eb0e81b5f0bbb451 ("ASoC: atmel: mchp-pdmc: add PDMC driver")
> Signed-off-by: Alviro Iskandar Setiawan <alviro.iskandar@xxxxxxxxxxx>

Reviewed-by: Codrin Ciubotariu <codrin.ciubotariu@xxxxxxxxxxxxx>

Thank you!