Re: [PATCH] PCI: Remove the deprecated "pci-dma-compat.h" API

From: Bjorn Helgaas
Date: Thu Mar 10 2022 - 12:30:33 EST


On Thu, Mar 10, 2022 at 11:04:45AM -0600, Bjorn Helgaas wrote:
> On Wed, Mar 09, 2022 at 08:50:39PM +0100, Christophe JAILLET wrote:
> > Now that all usages of the functions defined in "pci-dma-compat.h" have
> > been removed, it is time to remove this file as well.
>
> As of 1db333d9a51f ("Merge tag 'spi-fix-v5.17-rc7' of
> git://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi"), all the
> following still appear to be used:
>
> git grep -E "\<PCI_DMA_(BIDIRECTIONAL|TODEVICE|FROMDEVICE|NONE)"
> git grep -E "pci_(alloc|zalloc|free)_consistent"
> git grep -E "pci_(map|unmap)_single"
> git grep -E "\<pci_(map|unmap)_page"
> git grep -E "pci_(map|unmap)_sg"
> git grep -E "pci_dma_sync_"
> git grep pci_dma_mapping_error
> git grep -E "pci_set_.*dma_mask"

Christoph mentioned several other trees that this depends on, and
those would likely be in linux-next, but not yet in Linus' tree. The
above poking around is from the tip of Linus' tree, which was the
wrong place for me to look.

But I did the same in current linux-next, 71941773e143 ("Add
linux-next specific files for 20220310"), and still found quite a few
uses. Some are in comments, printks, coccinelle scripts, etc. I
would assume we'd want to remove them all?

Bjorn