Re: [PATCH] net: bcmgenet: Don't claim WOL when its not available

[Florian Fainelli]

On 3/9/22 8:55 PM, Jeremy Linton wrote:
> Some of the bcmgenet platforms don't correctly support WOL, yet
> ethtool returns:
> 
> "Supports Wake-on: gsf"
> 
> which is false.
> 
> Ideally if there isn't a wol_irq, or there is something else that
> keeps the device from being able to wakeup it should display:
> 
> "Supports Wake-on: d"
> 
> This patch checks whether the device can wakup, before using the
> hard-coded supported flags. This corrects the ethtool reporting, as
> well as the WOL configuration because ethtool verifies that the mode
> is supported before attempting it.
> 
> Signed-off-by: Jeremy Linton <jeremy.linton@xxxxxxx>

Acked-by: Florian Fainelli <f.fainelli@xxxxxxxxx>
Fixes: c51de7f3976b ("net: bcmgenet: add Wake-on-LAN support code")

Thanks Jeremy!
-- 
Florian

Attachment: smime.p7s
Description: S/MIME Cryptographic Signature