Re: [PATCH 5/5] staging: vt6656: Remove unused rf_type in card.c

From: kernel test robot
Date: Thu Mar 10 2022 - 16:31:11 EST


Hi Philipp,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on staging/staging-testing]

url: https://github.com/0day-ci/linux/commits/Philipp-Hortmann/staging-vt6656-Remove-unused-5GHz-support/20220311-025658
base: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git b25c7dc13fb8842e8634bd846a7a96f2176f0244
config: sh-allmodconfig (https://download.01.org/0day-ci/archive/20220311/202203110539.GOSgwFnJ-lkp@xxxxxxxxx/config)
compiler: sh4-linux-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/0day-ci/linux/commit/ddc1ba8087bf857aa6120e70814d4f161aba6cdc
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Philipp-Hortmann/staging-vt6656-Remove-unused-5GHz-support/20220311-025658
git checkout ddc1ba8087bf857aa6120e70814d4f161aba6cdc
# save the config file to linux build tree
mkdir build_dir
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross O=build_dir ARCH=sh SHELL=/bin/bash drivers/staging/vt6656/

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@xxxxxxxxx>

All warnings (new ones prefixed by >>):

drivers/staging/vt6656/card.c: In function 'vnt_set_bss_mode':
>> drivers/staging/vt6656/card.c:441:23: warning: variable 'bb_vga_0' set but not used [-Wunused-but-set-variable]
441 | unsigned char bb_vga_0 = 0x1c;
| ^~~~~~~~


vim +/bb_vga_0 +441 drivers/staging/vt6656/card.c

92b96797118e58 Forest Bond 2009-06-13 435
81969fd8abc104 Oscar Carter 2020-04-25 436 int vnt_set_bss_mode(struct vnt_private *priv)
92b96797118e58 Forest Bond 2009-06-13 437 {
35452e10610617 Oscar Carter 2020-04-29 438 int ret;
91387f5eb9fc22 Oscar Carter 2020-04-29 439 unsigned char type = priv->bb_type;
91387f5eb9fc22 Oscar Carter 2020-04-29 440 unsigned char data = 0;
91387f5eb9fc22 Oscar Carter 2020-04-29 @441 unsigned char bb_vga_0 = 0x1c;

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@xxxxxxxxxxxx