Re: [v2 2/2] ASoC: mediatek: mt8192: support rt1015p_rt5682s
From: kernel test robot
Date: Thu Mar 10 2022 - 16:31:18 EST
Hi Jiaxin,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on broonie-sound/for-next]
[also build test WARNING on next-20220310]
[cannot apply to broonie-spi/for-next robh/for-next v5.17-rc7]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Jiaxin-Yu/ASoC-mediatek-mt8192-support-rt1015p_rt5682s/20220310-233935
base: https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next
config: arm64-allmodconfig (https://download.01.org/0day-ci/archive/20220311/202203110529.Y6LSPpwn-lkp@xxxxxxxxx/config)
compiler: clang version 15.0.0 (https://github.com/llvm/llvm-project 276ca87382b8f16a65bddac700202924228982f6)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# install arm64 cross compiling tool for clang build
# apt-get install binutils-aarch64-linux-gnu
# https://github.com/0day-ci/linux/commit/0342dabf16890d0fa839ccbedcb3fee8936cd749
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Jiaxin-Yu/ASoC-mediatek-mt8192-support-rt1015p_rt5682s/20220310-233935
git checkout 0342dabf16890d0fa839ccbedcb3fee8936cd749
# save the config file to linux build tree
mkdir build_dir
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=arm64 SHELL=/bin/bash sound/soc/mediatek/mt8192/
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@xxxxxxxxx>
All warnings (new ones prefixed by >>):
>> sound/soc/mediatek/mt8192/mt8192-mt6359-rt1015-rt5682.c:1170:21: warning: data argument not used by format string [-Wformat-extra-args]
__func__, dai_link->name);
^
sound/soc/mediatek/mt8192/mt8192-mt6359-rt1015-rt5682.c:1177:21: warning: data argument not used by format string [-Wformat-extra-args]
__func__, dai_link->name);
^
2 warnings generated.
vim +1170 sound/soc/mediatek/mt8192/mt8192-mt6359-rt1015-rt5682.c
1115
1116 static int mt8192_mt6359_dev_probe(struct platform_device *pdev)
1117 {
1118 struct snd_soc_card *card;
1119 struct device_node *platform_node, *hdmi_codec, *headset_codec, *speaker_codec;
1120 int ret, i;
1121 struct snd_soc_dai_link *dai_link;
1122 struct mt8192_mt6359_priv *priv;
1123 struct device *dev;
1124
1125 card = (struct snd_soc_card *)of_device_get_match_data(&pdev->dev);
1126 if (!card)
1127 return -EINVAL;
1128 card->dev = &pdev->dev;
1129 dev = &pdev->dev;
1130
1131 if (of_device_is_compatible(dev->of_node, RT1015P_RT5682_OF_NAME))
1132 card->name = RT1015P_RT5682_CARD_NAME;
1133 else if (of_device_is_compatible(dev->of_node, RT1015P_RT5682S_OF_NAME))
1134 card->name = RT1015P_RT5682S_CARD_NAME;
1135 else
1136 dev_dbg(dev, "No need to set card name\n");
1137
1138 platform_node = of_parse_phandle(dev->of_node, "mediatek,platform", 0);
1139 if (!platform_node) {
1140 ret = -EINVAL;
1141 dev_err_probe(dev, ret, "Property 'platform' missing or invalid\n");
1142 goto err_platform_node;
1143 }
1144
1145 hdmi_codec = of_parse_phandle(dev->of_node, "mediatek,hdmi-codec", 0);
1146 if (!hdmi_codec) {
1147 ret = -EINVAL;
1148 dev_err_probe(dev, ret, "Property 'hdmi-codec' missing or invalid\n");
1149 goto err_hdmi_codec;
1150 }
1151
1152 speaker_codec = of_get_child_by_name(dev->of_node, "mediatek,speaker-codec");
1153 if (!speaker_codec) {
1154 ret = -EINVAL;
1155 dev_err_probe(dev, ret, "Property 'speaker_codec' missing or invalid\n");
1156 goto err_speaker_codec;
1157 }
1158
1159 headset_codec = of_get_child_by_name(dev->of_node, "mediatek,headset-codec");
1160 if (!headset_codec) {
1161 ret = -EINVAL;
1162 dev_err_probe(dev, ret, "Property 'headset_codec' missing or invalid\n");
1163 goto err_headset_codec;
1164 }
1165
1166 for_each_card_prelinks(card, i, dai_link) {
1167 ret = mt8192_mt6359_card_set_be_link(card, dai_link, speaker_codec, "I2S3");
1168 if (ret) {
1169 dev_err_probe(&pdev->dev, ret, "%s set speaker_codec fail\n",
> 1170 __func__, dai_link->name);
1171 goto err_probe;
1172 }
1173
1174 ret = mt8192_mt6359_card_set_be_link(card, dai_link, headset_codec, "I2S8");
1175 if (ret) {
1176 dev_err_probe(&pdev->dev, ret, "%s set headset_codec fail\n",
1177 __func__, dai_link->name);
1178 goto err_probe;
1179 }
1180
1181 ret = mt8192_mt6359_card_set_be_link(card, dai_link, headset_codec, "I2S9");
1182 if (ret) {
1183 dev_err_probe(&pdev->dev, ret, "%s set %s headset_codec fail\n",
1184 __func__, dai_link->name);
1185 goto err_probe;
1186 }
1187
1188 if (hdmi_codec && strcmp(dai_link->name, "TDM") == 0) {
1189 dai_link->codecs->of_node = hdmi_codec;
1190 dai_link->ignore = 0;
1191 }
1192
1193 if (strcmp(dai_link->codecs[0].dai_name, RT1015_CODEC_DAI) == 0)
1194 dai_link->ops = &mt8192_rt1015_i2s_ops;
1195
1196 if (!dai_link->platforms->name)
1197 dai_link->platforms->of_node = platform_node;
1198 }
1199
1200 priv = devm_kzalloc(&pdev->dev, sizeof(*priv), GFP_KERNEL);
1201 if (!priv) {
1202 ret = -ENOMEM;
1203 goto err_probe;
1204 }
1205 snd_soc_card_set_drvdata(card, priv);
1206
1207 ret = mt8192_afe_gpio_init(&pdev->dev);
1208 if (ret) {
1209 dev_err_probe(&pdev->dev, ret, "%s init gpio error\n", __func__);
1210 goto err_probe;
1211 }
1212
1213 ret = devm_snd_soc_register_card(&pdev->dev, card);
1214 if (ret)
1215 dev_err_probe(&pdev->dev, ret,
1216 "%s snd_soc_register_card fail\n", __func__);
1217
1218 err_probe:
1219 of_node_put(headset_codec);
1220 err_headset_codec:
1221 of_node_put(speaker_codec);
1222 err_speaker_codec:
1223 of_node_put(hdmi_codec);
1224 err_hdmi_codec:
1225 of_node_put(platform_node);
1226 err_platform_node:
1227
1228 return ret;
1229 }
1230
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@xxxxxxxxxxxx