Re: [PATCH] drivers/bus/brcmstb_gisb.c : Remove the suppress_bind_attrs attribute of the driver

From: Andy Shevchenko
Date: Tue Mar 22 2022 - 10:57:19 EST


On Tue, Mar 22, 2022 at 4:52 PM Andy Shevchenko
<andy.shevchenko@xxxxxxxxx> wrote:
> On Tue, Mar 22, 2022 at 12:41 AM lizhe <sensor1010@xxxxxxx> wrote:
> >
> > Even if platform_driver does not set suppress_bind_attrs attribute,
> > when registering with platform_driver_probe, the value of
> > suppress_bind_attrs is still true, see __platform_driver_probe()
>
> Any reasons it can't be switched to builtin_platform_driver() macro
> and hence constification of the driver structure?

Ah, the patch that brought that assignment actually allows to built
the driver as a module, so, the correct patch would be to switch to
module_platform_driver() I suppose.

--
With Best Regards,
Andy Shevchenko