Re: [PATCH v2,1/2] dt-bindings: display: mediatek: dpi: Add compatible for MediaTek MT8186

[Rex-BC Chen]

On Wed, 2022-04-06 at 14:38 +0800, CK Hu wrote:
> Hi,
> 
> On Fri, 2022-04-01 at 09:38 +0800, Rex-BC Chen wrote:
> > On Thu, 2022-03-31 at 19:58 +0800, xinlei.lee@xxxxxxxxxxxx wrote:
> > > From: Xinlei Lee <xinlei.lee@xxxxxxxxxxxx>
> > > 
> > > Add dt-binding documentation of dpi for MediaTek MT8186 SoC.
> > > 
> > > Signed-off-by: Xinlei Lee <xinlei.lee@xxxxxxxxxxxx>
> > > ---
> > >  .../devicetree/bindings/display/mediatek/mediatek,dpi.yaml      
> > >  |
> > > 1
> > > +
> > >  1 file changed, 1 insertion(+)
> > > 
> > > diff --git
> > > a/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi
> > > .y
> > > am
> > > l
> > > b/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi
> > > .y
> > > am
> > > l
> > > index dd2896a40ff0..a73044c50b5f 100644
> > > ---
> > > a/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi
> > > .y
> > > am
> > > l
> > > +++
> > > b/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi
> > > .y
> > > am
> > > l
> > > @@ -22,6 +22,7 @@ properties:
> > >        - mediatek,mt7623-dpi
> > >        - mediatek,mt8173-dpi
> > >        - mediatek,mt8183-dpi
> > > +      - mediatek,mt8186-dpi
> > >        - mediatek,mt8192-dpi
> > >  
> > >    reg:
> > 
> > Hello Xinlei,
> > 
> > From the dts we use, the dpi node needs other properties for
> > MT8186.
> > Please send another patch and add these properties to binding.
> > 
> > assigned-clocks = <&topckgen CLK_TOP_DPI>;
> > assigned-clock-parents = <&topckgen CLK_TOP_TVDPLL_D2>;
> 
> According to [1], the assigned-clocks is initial value. Without this
> initial value, I think driver would set this clock again, wouldn't
> it?
> 
> [1] 
> 
https://www.kernel.org/doc/Documentation/devicetree/bindings/clock/clock-bindings.txt
> 
> Regards,
> CK
> 

Hello CK,

OK, Thanks for your explanation.


Reviewed-by: Rex-BC Chen <rex-bc.chen@xxxxxxxxxxxx>

BRs,
Rex
> > 
> > Thanks
> > 
> > BRs,
> > Rex
> > 
> > 
> > _______________________________________________
> > Linux-mediatek mailing list
> > Linux-mediatek@xxxxxxxxxxxxxxxxxxx
> > 
> 
> 
https://urldefense.com/v3/__http://lists.infradead.org/mailman/listinfo/linux-mediatek__;!!CTRNKA9wMg0ARbw!wtF15QZZTCzWfRpxNLjZ1VQQ54i40D8STuOo0h18dtz3es-ksLfYQGTEFlb7lg$
> >  
> 
>