Re: [PATCH v2 2/2] libata: Inline ata_qc_new_init() in ata_scsi_qc_new()

[John Garry]

On 06/04/2022 02:48, Damien Le Moal wrote:
> On 4/5/22 14:52, Christoph Hellwig wrote:
> > On Mon, Apr 04, 2022 at 10:53:10PM +0800, John Garry wrote:
> > > From: Christoph Hellwig <hch@xxxxxx>
> > >
> > > It is a bit pointless to have ata_qc_new_init() in libata-core.c 
> > > since it
> > > pokes scsi internals, so inline it in ata_scsi_qc_new() (in 
> > > libata-scsi.c).
> > >
> > > <Christoph, please provide signed-off-by>
> > > [jpg, Take Christoph's change from list and form into a patch]
> > > Signed-off-by: John Garry <john.garry@xxxxxxxxxx>
> >
> > Signed-off-by: Christoph Hellwig <hch@xxxxxx>
> >
> > Although I still think merging the two patches into one to avoid all
> > the churn would be much better.
>
> I agree. Let's merge these 2 patches.

I'd say that they are distinct changes.

Anyway, if that is the preference then who shall be the author? 
Considering I did most effort I will be and add Christoph as 
co-developed-by - please let me know if not ok.

thanks,
John