Re: [PATCH v2] macintosh: via-pmu and via-cuda need RTC_LIB

[Arnd Bergmann]

On Sun, Apr 10, 2022 at 6:10 PM Randy Dunlap <rdunlap@xxxxxxxxxxxxx> wrote:
>
> Fix build when RTC_LIB is not set/enabled.
> Eliminates these build errors:
>
> m68k-linux-ld: drivers/macintosh/via-pmu.o: in function `pmu_set_rtc_time':
> drivers/macintosh/via-pmu.c:1769: undefined reference to `rtc_tm_to_time64'
> m68k-linux-ld: drivers/macintosh/via-cuda.o: in function `cuda_set_rtc_time':
> drivers/macintosh/via-cuda.c:797: undefined reference to `rtc_tm_to_time64'
>
> Fixes: 0792a2c8e0bb ("macintosh: Use common code to access RTC")
> Signed-off-by: Randy Dunlap <rdunlap@xxxxxxxxxxxxx>
> Reported-by: kernel test robot <lkp@xxxxxxxxx>
> Suggested-by: Christophe Leroy <christophe.leroy@xxxxxxxxxx>
> Cc: Benjamin Herrenschmidt <benh@xxxxxxxxxxxxxxxxxxx>
> Cc: Michael Ellerman <mpe@xxxxxxxxxxxxxx>
> Cc: Kees Cook <keescook@xxxxxxxxxxxx>
> Cc: Arnd Bergmann <arnd@xxxxxxxx>
> Cc: Finn Thain <fthain@xxxxxxxxxxxxxx>
> Cc: Geert Uytterhoeven <geert@xxxxxxxxxxxxxx>
> Cc: Nathan Chancellor <nathan@xxxxxxxxxx>
> Cc: Nick Desaulniers <ndesaulniers@xxxxxxxxxx>
> Cc: linuxppc-dev@xxxxxxxxxxxxxxxx
> ---
> v2: use RTC_LIB instead of open-coding the call to rtc_tm_to_time64()

This sounds like a step in the right direction. Note that there is
another open-coded rtc_tm_to_time64() in read_persistent_clock64(),
it might be worth changing that one as well and just always including
RTC_LIB, though that's a separate issue.

Acked-by: Arnd Bergmann <arnd@xxxxxxxx>

> --- a/drivers/macintosh/Kconfig
> +++ b/drivers/macintosh/Kconfig
> @@ -44,6 +44,7 @@ config ADB_IOP
>  config ADB_CUDA
>         bool "Support for Cuda/Egret based Macs and PowerMacs"
>         depends on (ADB || PPC_PMAC) && !PPC_PMAC64
> +       select RTC_LIB
>         help
>           This provides support for Cuda/Egret based Macintosh and
>           Power Macintosh systems. This includes most m68k based Macs,
> @@ -57,6 +58,7 @@ config ADB_CUDA
>  config ADB_PMU
>         bool "Support for PMU based PowerMacs and PowerBooks"
>         depends on PPC_PMAC || MAC
> +       select RTC_LIB
>         help
>           On PowerBooks, iBooks, and recent iMacs and Power Macintoshes, the
>           PMU is an embedded microprocessor whose primary function is to

I think ideally these would just become regular RTC drivers, rather than
relying on the roundtrip through CONFIG_RTC_DRV_GENERIC.

        Arnd