Re: [PATCH 1/6] staging: r8188eu: drop unnecessary wrapper rtw_free_cmd_priv

[Dan Carpenter]

On Sun, Apr 10, 2022 at 11:08:02PM +0530, Vihas Makwana wrote:
> > On Sun, 2022-04-10 at 22:01 +0530, Vihas Makwana wrote:
> > > Remove the unnecessary wrapper. The logic of rtw_free_cmd_priv can
> > > be moved to _rtw_free_cmd_priv.
> >
> > If you are going to drop wrappers, my preference would be
> > to drop the underscore prefixed ones.
> >
> Yes, that was my initial thought too. But there are already some init
> and free functions in the module with underscores prefixed.
> So I didn't do it that way. Maybe the developers kept it that way for
> some reason.

Yeah, no.  There is no reason.  Get rid of the underscores.

regards,
dan carpenter