Re: [PATCH v3 2/5] dt-bindings: display: ssd1307fb: Extend schema for SPI controllers

[Geert Uytterhoeven]

Hi Javier,

On Tue, Apr 12, 2022 at 6:27 PM Javier Martinez Canillas
<javierm@xxxxxxxxxx> wrote:
> The Solomon SSD130x OLED displays can either have an I2C or SPI interface,
> add to the schema the properties and examples for OLED devices under SPI.
>
> Signed-off-by: Javier Martinez Canillas <javierm@xxxxxxxxxx>
> Acked-by: Mark Brown <broonie@xxxxxxxxxx>
> Reviewed-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>
> ---
>
> Changes in v3:
> - Add a comment to the properties required for SPI (Geert Uytterhoeven)

Thanks for the update!

> --- a/Documentation/devicetree/bindings/display/solomon,ssd1307fb.yaml
> +++ b/Documentation/devicetree/bindings/display/solomon,ssd1307fb.yaml
> @@ -38,9 +38,16 @@ properties:
>    reset-gpios:
>      maxItems: 1
>
> +  # Only required for SPI
> +  dc-gpios:
> +    maxItems: 1

Actually I meant to also add a description, like for vbat-supply below,
to explain the meaning of "dc".

> +
>    vbat-supply:
>      description: The supply for VBAT

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds