Re: [PATCH v3 2/5] dt-bindings: display: ssd1307fb: Extend schema for SPI controllers

[Javier Martinez Canillas]

Hello Geert,

On 4/13/22 10:04, Geert Uytterhoeven wrote:
> Hi Javier,
> 
> On Tue, Apr 12, 2022 at 6:27 PM Javier Martinez Canillas
> <javierm@xxxxxxxxxx> wrote:
>> The Solomon SSD130x OLED displays can either have an I2C or SPI interface,
>> add to the schema the properties and examples for OLED devices under SPI.
>>
>> Signed-off-by: Javier Martinez Canillas <javierm@xxxxxxxxxx>
>> Acked-by: Mark Brown <broonie@xxxxxxxxxx>
>> Reviewed-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>
>> ---
>>
>> Changes in v3:
>> - Add a comment to the properties required for SPI (Geert Uytterhoeven)
> 
> Thanks for the update!
> 
>> --- a/Documentation/devicetree/bindings/display/solomon,ssd1307fb.yaml
>> +++ b/Documentation/devicetree/bindings/display/solomon,ssd1307fb.yaml
>> @@ -38,9 +38,16 @@ properties:
>>    reset-gpios:
>>      maxItems: 1
>>
>> +  # Only required for SPI
>> +  dc-gpios:
>> +    maxItems: 1
> 
> Actually I meant to also add a description, like for vbat-supply below,
> to explain the meaning of "dc".
>

Ahh, sorry for misunderstanding you! Something like the following looks good ?

  # Only required for SPI
  dc-gpios:
    description:
      GPIO connected to the controller's D/C# (Data/Command) pin,
      that is needed for 4-wire SPI to tell the controller if the
      data sent is for a command register or the display data RAM
    maxItems: 1

If you agree with that, then can squash before pushing or add it to a v4
if another revision is needed.

-- 
Best regards,

Javier Martinez Canillas
Linux Engineering
Red Hat