Re: [PATCH v5 1/3] selftests: bpf: add test for bpf_skb_change_proto

[Daniel Borkmann]

On 4/18/22 3:52 AM, Lina.Wang@xxxxxxxxxxxx wrote:
[...]
> > OT: In Cilium we run similar NAT46/64 translation for XDP and tc/BPF
> > for our LB services [4] (that is,
> > v4 VIP with v6 backends, and v6 VIP with v4 backends).
> >
> >     [4]
> > https://github.com/cilium/cilium/blob/master/bpf/lib/nat_46x64.h
> >         
> > https://github.com/cilium/cilium/blob/master/test/nat46x64/test.sh
>
> It is complicated for me, my case doesnot use XDP driver.I use xdp_dummy
> just to enable veth NAPI GRO, not real XDP driver code. My test case is
> simple and enough for my patch, I think. I have covered tcp and udp,
> normal and SO_SEGMENT.

Ok, fair enough, then lets resend with the minor fixups as discussed
earlier and worst case we can do the test_progs integration at a later
point to avoid blocking the fix. At least there is something runnable
under net/bpf selftests.. even if not yet in BPF CI but we can follow-up
on it later. Thanks Lina!