RE: [PATCH 07/10] ARM: dts: s5pv210: use proper 'dma-channels/requests' properties

From: Alim Akhtar
Date: Wed Apr 27 2022 - 12:46:01 EST




>-----Original Message-----
>From: Krzysztof Kozlowski [mailto:krzysztof.kozlowski@xxxxxxxxxx]
>Sent: Wednesday, April 27, 2022 9:29 PM
>To: Lee Jones <lee.jones@xxxxxxxxxx>; Rob Herring <robh+dt@xxxxxxxxxx>;
>Krzysztof Kozlowski <krzysztof.kozlowski+dt@xxxxxxxxxx>; Alim Akhtar
><alim.akhtar@xxxxxxxxxxx>; Dinh Nguyen <dinguyen@xxxxxxxxxx>; Michal
>Simek <michal.simek@xxxxxxxxxx>; Liviu Dudau <liviu.dudau@xxxxxxx>;
>Sudeep Holla <sudeep.holla@xxxxxxx>; Lorenzo Pieralisi
><lorenzo.pieralisi@xxxxxxx>; Ray Jui <rjui@xxxxxxxxxxxx>; Scott Branden
><sbranden@xxxxxxxxxxxx>; Broadcom Kernel Team <bcm-kernel-feedback-
>list@xxxxxxxxxxxx>; Sylwester Nawrocki <s.nawrocki@xxxxxxxxxxx>;
>devicetree@xxxxxxxxxxxxxxx; linux-arm-kernel@xxxxxxxxxxxxxxxxxxx; linux-
>samsung-soc@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx
>Cc: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>; Rob Herring
><robh@xxxxxxxxxx>
>Subject: [PATCH 07/10] ARM: dts: s5pv210: use proper 'dma-
>channels/requests' properties
>
>pl330 DMA controller bindings documented 'dma-channels' and 'dma-
>requests' properties (without leading hash sign), so fix the DTS to match
the
>bindings.
>
>Reported-by: Rob Herring <robh@xxxxxxxxxx>
>Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>
>---

Reviewed-by: Alim Akhtar <alim.akhtar@xxxxxxxxxxx>


> arch/arm/boot/dts/s5pv210.dtsi | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)
>
>diff --git a/arch/arm/boot/dts/s5pv210.dtsi
b/arch/arm/boot/dts/s5pv210.dtsi
>index ac281f42e8f5..f6988ba3393d 100644
>--- a/arch/arm/boot/dts/s5pv210.dtsi
>+++ b/arch/arm/boot/dts/s5pv210.dtsi
>@@ -125,8 +125,8 @@ pdma0: dma-controller@e0900000 {
> clocks = <&clocks CLK_PDMA0>;
> clock-names = "apb_pclk";
> #dma-cells = <1>;
>- #dma-channels = <8>;
>- #dma-requests = <32>;
>+ dma-channels = <8>;
>+ dma-requests = <32>;
> };
>
> pdma1: dma-controller@e0a00000 {
>@@ -137,8 +137,8 @@ pdma1: dma-controller@e0a00000 {
> clocks = <&clocks CLK_PDMA1>;
> clock-names = "apb_pclk";
> #dma-cells = <1>;
>- #dma-channels = <8>;
>- #dma-requests = <32>;
>+ dma-channels = <8>;
>+ dma-requests = <32>;
> };
>
> adc: adc@e1700000 {
>@@ -526,8 +526,8 @@ mdma1: dma-controller@fa200000 {
> clocks = <&clocks CLK_MDMA>;
> clock-names = "apb_pclk";
> #dma-cells = <1>;
>- #dma-channels = <8>;
>- #dma-requests = <1>;
>+ dma-channels = <8>;
>+ dma-requests = <1>;
> };
>
> rotator: rotator@fa300000 {
>--
>2.32.0