RE: [PATCH 09/10] arm64: dts: exynos: use proper 'dma-channels/requests' properties

From: Alim Akhtar
Date: Wed Apr 27 2022 - 12:46:53 EST




>-----Original Message-----
>From: Krzysztof Kozlowski [mailto:krzysztof.kozlowski@xxxxxxxxxx]
>Sent: Wednesday, April 27, 2022 9:29 PM
>To: Lee Jones <lee.jones@xxxxxxxxxx>; Rob Herring <robh+dt@xxxxxxxxxx>;
>Krzysztof Kozlowski <krzysztof.kozlowski+dt@xxxxxxxxxx>; Alim Akhtar
><alim.akhtar@xxxxxxxxxxx>; Dinh Nguyen <dinguyen@xxxxxxxxxx>; Michal
>Simek <michal.simek@xxxxxxxxxx>; Liviu Dudau <liviu.dudau@xxxxxxx>;
>Sudeep Holla <sudeep.holla@xxxxxxx>; Lorenzo Pieralisi
><lorenzo.pieralisi@xxxxxxx>; Ray Jui <rjui@xxxxxxxxxxxx>; Scott Branden
><sbranden@xxxxxxxxxxxx>; Broadcom Kernel Team <bcm-kernel-feedback-
>list@xxxxxxxxxxxx>; Sylwester Nawrocki <s.nawrocki@xxxxxxxxxxx>;
>devicetree@xxxxxxxxxxxxxxx; linux-arm-kernel@xxxxxxxxxxxxxxxxxxx; linux-
>samsung-soc@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx
>Cc: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>; Rob Herring
><robh@xxxxxxxxxx>
>Subject: [PATCH 09/10] arm64: dts: exynos: use proper 'dma-
>channels/requests' properties
>
>pl330 DMA controller bindings documented 'dma-channels' and 'dma-
>requests' properties (without leading hash sign), so fix the DTS to match
the
>bindings.
>
>Reported-by: Rob Herring <robh@xxxxxxxxxx>
>Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>
>---

Reviewed-by: Alim Akhtar <alim.akhtar@xxxxxxxxxxx>


> arch/arm64/boot/dts/exynos/exynos5433.dtsi | 12 ++++++------
> arch/arm64/boot/dts/exynos/exynos7.dtsi | 8 ++++----
> 2 files changed, 10 insertions(+), 10 deletions(-)
>
>diff --git a/arch/arm64/boot/dts/exynos/exynos5433.dtsi
>b/arch/arm64/boot/dts/exynos/exynos5433.dtsi
>index 017ccc2f4650..91e82e4283b2 100644
>--- a/arch/arm64/boot/dts/exynos/exynos5433.dtsi
>+++ b/arch/arm64/boot/dts/exynos/exynos5433.dtsi
>@@ -1866,8 +1866,8 @@ pdma0: dma-controller@15610000 {
> clocks = <&cmu_fsys CLK_PDMA0>;
> clock-names = "apb_pclk";
> #dma-cells = <1>;
>- #dma-channels = <8>;
>- #dma-requests = <32>;
>+ dma-channels = <8>;
>+ dma-requests = <32>;
> };
>
> pdma1: dma-controller@15600000 {
>@@ -1877,8 +1877,8 @@ pdma1: dma-controller@15600000 {
> clocks = <&cmu_fsys CLK_PDMA1>;
> clock-names = "apb_pclk";
> #dma-cells = <1>;
>- #dma-channels = <8>;
>- #dma-requests = <32>;
>+ dma-channels = <8>;
>+ dma-requests = <32>;
> };
>
> audio-subsystem@11400000 {
>@@ -1898,8 +1898,8 @@ adma: dma-controller@11420000 {
> clocks = <&cmu_aud CLK_ACLK_DMAC>;
> clock-names = "apb_pclk";
> #dma-cells = <1>;
>- #dma-channels = <8>;
>- #dma-requests = <32>;
>+ dma-channels = <8>;
>+ dma-requests = <32>;
> power-domains = <&pd_aud>;
> };
>
>diff --git a/arch/arm64/boot/dts/exynos/exynos7.dtsi
>b/arch/arm64/boot/dts/exynos/exynos7.dtsi
>index e38bb02a2152..c31534771620 100644
>--- a/arch/arm64/boot/dts/exynos/exynos7.dtsi
>+++ b/arch/arm64/boot/dts/exynos/exynos7.dtsi
>@@ -149,8 +149,8 @@ pdma0: dma-controller@10e10000 {
> clocks = <&clock_fsys0 ACLK_PDMA0>;
> clock-names = "apb_pclk";
> #dma-cells = <1>;
>- #dma-channels = <8>;
>- #dma-requests = <32>;
>+ dma-channels = <8>;
>+ dma-requests = <32>;
> };
>
> pdma1: dma-controller@10eb0000 {
>@@ -160,8 +160,8 @@ pdma1: dma-controller@10eb0000 {
> clocks = <&clock_fsys0 ACLK_PDMA1>;
> clock-names = "apb_pclk";
> #dma-cells = <1>;
>- #dma-channels = <8>;
>- #dma-requests = <32>;
>+ dma-channels = <8>;
>+ dma-requests = <32>;
> };
>
> clock_topc: clock-controller@10570000 {
>--
>2.32.0