Re: [PATCH] writeback: Avoid skipping inode writeback

[Christoph Hellwig]

On Thu, May 05, 2022 at 09:47:31PM +0800, Jing Xia wrote:
>  	if (!(inode->i_state & I_DIRTY_ALL))
>  		inode_cgwb_move_to_attached(inode, wb);
> +	else if (!(inode->i_state & I_SYNC_QUEUED) && (inode->i_state & I_DIRTY))

Please turn this into

	else if ((inode->i_state & I_DIRTY) &&
	         !(inode->i_state & I_SYNC_QUEUED))

to keep it a little more readable.

Otherwise looks good:

Reviewed-by: Christoph Hellwig <hch@xxxxxx>