Re: [PATCHv2] speakup: Generate speakupmap.h automatically

[Greg KH]

On Mon, May 09, 2022 at 04:26:42PM +0200, Samuel Thibault wrote:
> Greg KH, le lun. 09 mai 2022 16:19:03 +0200, a ecrit:
> > On Mon, May 09, 2022 at 04:07:05PM +0200, Samuel Thibault wrote:
> > > Greg KH, le lun. 09 mai 2022 16:04:43 +0200, a ecrit:
> > > > Any reason you can't add the code in utils.c into genmap.c and then
> > > > merge into makemapdata.c to make this a single .c file that does both
> > > > things?
> > > 
> > > Yes: genmap is a tool that end-users can use without needing the Linux
> > > source code, while makemapdata needs it.
> > 
> > But who will run genmap?
> 
> I guess you meant makemapdata?
> 
> Long-term-wise this patchset will need a bit of work to properly install
> the genmap tool so the user can call it.  I'm here mostly making sure
> to put into the Linux kernel how speakupmap.h is generated (rather
> than the currently very magic file), while at the same time keeping
> the separation between makemapdata and genmap that will make sense
> longterm-wise.

Ok, then it's ok to leave it as is.  But the build stuff still needs to
get resolved :)