Re: [PATCH] dt-bindings: Remove example file on dt-extract-example error

[Masahiro Yamada]

On Wed, May 11, 2022 at 7:13 AM Rob Herring <robh@xxxxxxxxxx> wrote:
>
> As 'dt-extract-example' writes the example dts files to stdout, a file
> is always created even on an error such as Ctrl-C. The resulting empty
> file(s) then cause unexpected errors on subsequent builds. Fix this by
> removing the output file on any error.
>


Did you really set it?


The target deletion on interrupt is automatic
since the following commit:



commit 9c2af1c7377a8a6ef86e5cabf80978f3dbbb25c0
Author: Masahiro Yamada <yamada.masahiro@xxxxxxxxxxxxx>
Date:   Fri Jul 20 16:46:33 2018 +0900

    kbuild: add .DELETE_ON_ERROR special target









> Signed-off-by: Rob Herring <robh@xxxxxxxxxx>
> ---
>  Documentation/devicetree/bindings/Makefile | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/Makefile b/Documentation/devicetree/bindings/Makefile
> index c9953f86b19d..c9fadff3dd74 100644
> --- a/Documentation/devicetree/bindings/Makefile
> +++ b/Documentation/devicetree/bindings/Makefile
> @@ -20,7 +20,7 @@ check_dtschema_version:
>         { echo "ERROR: dtschema minimum version is v$(DT_SCHEMA_MIN_VERSION)" >&2; false; }
>
>  quiet_cmd_extract_ex = DTEX    $@
> -      cmd_extract_ex = $(DT_EXTRACT_EX) $< > $@
> +      cmd_extract_ex = $(DT_EXTRACT_EX) $< > $@ || rm $@
>
>  $(obj)/%.example.dts: $(src)/%.yaml check_dtschema_version FORCE
>         $(call if_changed,extract_ex)
> --
> 2.34.1
>


-- 
Best Regards
Masahiro Yamada