Re: [PATCH v4 1/9] dt-bindings: i2c: npcm: support NPCM845

From: Tyrone Ting
Date: Tue May 10 2022 - 20:29:04 EST


Tyrone Ting <warp5tw@xxxxxxxxx> 於 2022年5月11日 週三 上午8:25寫道:
>
> Hi Krzysztof:
>
> Thank you for your review and it will be addressed.
>
> Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx> 於 2022年5月10日 週二 下午6:59寫道:
> >
> > On 10/05/2022 12:03, Tyrone Ting wrote:
> > >
> > > maintainers:
> > > - Tali Perry <tali.perry1@xxxxxxxxx>
> > >
> > > properties:
> > > compatible:
> > > - const: nuvoton,npcm750-i2c
> > > + enum:
> > > + - nuvoton,npcm750-i2c
> > > + - nuvoton,npcm845-i2c
> > >
> > > reg:
> > > maxItems: 1
> > > @@ -36,6 +37,10 @@ properties:
> > > default: 100000
> > > enum: [100000, 400000, 1000000]
> > >
> > > + nuvoton,sys-mgr:
> > > + $ref: "/schemas/types.yaml#/definitions/phandle"
> >
> > Minor nit: No quotes. The other places don't have it.
> >
> >
> > Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>
> >
> >
> > Best regards,
> > Krzysztof
>
> Best regards,
> Tyrone