Re: [PATCH v6 1/4] dt-bindings: thermal: k3-j72xx: Add VTM bindings documentation

From: Krzysztof Kozlowski
Date: Wed May 11 2022 - 04:16:09 EST


On 11/05/2022 09:53, J, KEERTHY wrote:
>>>
>>> Any comments on this version?
>>
>> You got Rob's review, so you don't need also mine.
>>
>> If you want, then in general look okay, except the description for "reg"
>> you could split per items:
>>
>> reg:
>> items:
>> - description: VTM cfg1 register space
>> - description: VTM cfg2 register space
>> - description: efuse register space
>>
>> It's more obvious what items you expect.
>
> Hi Krzysztof,
>
> DTEX
> Documentation/devicetree/bindings/thermal/ti,j72xx-thermal.example.dts
> Documentation/devicetree/bindings/thermal/ti,j72xx-thermal.yaml: found
> duplicate key "description" with value "VTM cfg2 register space"
> (original value: "VTM cfg1 register space")
> Documentation/devicetree/bindings/Makefile:26: recipe for target
> 'Documentation/devicetree/bindings/thermal/ti,j72xx-thermal.example.dts'
> failed
> make[1]: ***
> [Documentation/devicetree/bindings/thermal/ti,j72xx-thermal.example.dts] Er
>
> I believe multiple instances of description is failing. So can i keep
> the description as is?

It looks weird. Can you share your code (pastebin/github/paste here)?


Best regards,
Krzysztof