Re: [PATCH v1] module: Fix prefix for module.sig_enforce module param

From: Luis Chamberlain
Date: Thu Jun 02 2022 - 15:16:32 EST


On Wed, Jun 01, 2022 at 08:56:52PM -0700, Saravana Kannan wrote:
> Commit cfc1d277891e ("module: Move all into module/") changed the prefix
> of the module param by moving/renaming files. A later commit also moves
> the module_param() into a different file, thereby changing the prefix
> yet again.
>
> This would break kernel cmdline compatibility and also userspace
> compatibility at /sys/module/module/parameters/sig_enforce.
>
> So, set the prefix back to "module.".
>
> Cc: Aaron Tomlin <atomlin@xxxxxxxxxx>
> Cc: mcgrof@xxxxxxxxxx
> Cc: christophe.leroy@xxxxxxxxxx
> Cc: cl@xxxxxxxxx
> Cc: mbenes@xxxxxxx
> Cc: akpm@xxxxxxxxxxxxxxxxxxxx
> Cc: jeyu@xxxxxxxxxx
> Cc: linux-kernel@xxxxxxxxxxxxxxx
> Cc: linux-modules@xxxxxxxxxxxxxxx
> Cc: void@xxxxxxxxxxxxx
> Cc: atomlin@xxxxxxxxxxx
> Cc: allen.lkml@xxxxxxxxx
> Cc: joe@xxxxxxxxxxx
> Cc: msuchanek@xxxxxxx
> Cc: oleksandr@xxxxxxxxxxxxxx
> Cc: jason.wessel@xxxxxxxxxxxxx
> Cc: pmladek@xxxxxxxx
> Cc: daniel.thompson@xxxxxxxxxx
> Cc: hch@xxxxxxxxxxxxx
> Fixes: cfc1d277891e ("module: Move all into module/")
> Signed-off-by: Saravana Kannan <saravanak@xxxxxxxxxx>

Acked-by: Luis Chamberlain <mcgrof@xxxxxxxxxx>

Linus want to take this in or should I just queueu these up?

Luis