Re: [PATCH v1 1/1] iio: adc: lpc18xx_adc: Switch from of headers to mod_devicetable.h

From: Jonathan Cameron
Date: Fri Jun 03 2022 - 13:17:35 EST


On Wed, 1 Jun 2022 00:22:18 +0300
Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx> wrote:

> There is nothing directly using of specific interfaces in this driver,
> so lets not include the headers.
>
> While at it, drop dependency to OF, which currently makes no sense.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
Applied
> ---
> drivers/iio/adc/Kconfig | 2 +-
> drivers/iio/adc/lpc18xx_adc.c | 3 +--
> 2 files changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/iio/adc/Kconfig b/drivers/iio/adc/Kconfig
> index 448ae243cd31..b9e913e25a5d 100644
> --- a/drivers/iio/adc/Kconfig
> +++ b/drivers/iio/adc/Kconfig
> @@ -562,7 +562,7 @@ config LP8788_ADC
> config LPC18XX_ADC
> tristate "NXP LPC18xx ADC driver"
> depends on ARCH_LPC18XX || COMPILE_TEST
> - depends on OF && HAS_IOMEM
> + depends on HAS_IOMEM
> help
> Say yes here to build support for NXP LPC18XX ADC.
>
> diff --git a/drivers/iio/adc/lpc18xx_adc.c b/drivers/iio/adc/lpc18xx_adc.c
> index ae9c9384f23e..42e6cd6fa6f7 100644
> --- a/drivers/iio/adc/lpc18xx_adc.c
> +++ b/drivers/iio/adc/lpc18xx_adc.c
> @@ -17,10 +17,9 @@
> #include <linux/iio/driver.h>
> #include <linux/io.h>
> #include <linux/iopoll.h>
> +#include <linux/mod_devicetable.h>
> #include <linux/module.h>
> #include <linux/mutex.h>
> -#include <linux/of.h>
> -#include <linux/of_device.h>
> #include <linux/platform_device.h>
> #include <linux/regulator/consumer.h>
>