Re: [PATCH v1 1/1] iio: dac: ad5592r: Get rid of OF specifics

From: Jonathan Cameron
Date: Fri Jun 03 2022 - 13:19:49 EST


On Tue, 31 May 2022 16:53:20 +0300
Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx> wrote:

> Use dev_fwnode() instead of direct OF node dereference when checking
> for regulator API error code.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
Applied
> ---
> drivers/iio/dac/ad5592r-base.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/iio/dac/ad5592r-base.c b/drivers/iio/dac/ad5592r-base.c
> index 4434c1b2a322..7a9b5fc1e579 100644
> --- a/drivers/iio/dac/ad5592r-base.c
> +++ b/drivers/iio/dac/ad5592r-base.c
> @@ -603,7 +603,7 @@ int ad5592r_probe(struct device *dev, const char *name,
>
> st->reg = devm_regulator_get_optional(dev, "vref");
> if (IS_ERR(st->reg)) {
> - if ((PTR_ERR(st->reg) != -ENODEV) && dev->of_node)
> + if ((PTR_ERR(st->reg) != -ENODEV) && dev_fwnode(dev))
> return PTR_ERR(st->reg);
>
> st->reg = NULL;