Re: [PATCH 1/3] regulator: mp5416: alphabetically sort header includes

[Christophe JAILLET]

Le 04/06/2022 à 16:56, Robert Marko a écrit :
> Sort the header include list alphabetically.
>
> Signed-off-by: Robert Marko <robimarko@xxxxxxxxx>
> ---
>   drivers/regulator/mp5416.c | 6 +++---
>   1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/regulator/mp5416.c b/drivers/regulator/mp5416.c
> index 39cebec0edb6..d8245080df03 100644
> --- a/drivers/regulator/mp5416.c
> +++ b/drivers/regulator/mp5416.c
> @@ -6,14 +6,14 @@
>   //
>   // Author: Saravanan Sekar <sravanhome@xxxxxxxxx>
>   
> +#include <linux/err.h>
> +#include <linux/i2c.h>
> +#include <linux/init.h>
>   #include <linux/kernel.h>

Nitpick: it seems that kernel.h is not needed here. (at least it compile 
without it).

CJ

>   #include <linux/module.h>
> -#include <linux/init.h>
> -#include <linux/err.h>
>   #include <linux/platform_device.h>
>   #include <linux/regmap.h>
>   #include <linux/regulator/driver.h>
> -#include <linux/i2c.h>
>   
>   #define MP5416_REG_CTL0			0x00
>   #define MP5416_REG_CTL1			0x01