Re: 5.19-rc1 x86 build failure

From: Andrew Cooper
Date: Wed Jun 08 2022 - 05:55:22 EST


On 08/06/2022 01:59, Josh Poimboeuf wrote:
> @@ -133,12 +125,16 @@ asmlinkage void __init x86_64_start_reservations(char *real_mode_data);
>
> #endif /* __i386__ */
> #endif /* _SETUP */
> -#else
> -#define RESERVE_BRK(name,sz) \
> - .pushsection .brk_reservation,"aw",@nobits; \
> -.brk.name: \
> -1: .skip sz; \
> - .size .brk.name,.-1b; \
> +
> +#else /* __ASSEMBLY */
> +
> +#define RESERVE_BRK(name, size) \
> + .pushsection .brk_reservation, "aw"; \
> +__brk_##name: \
> +1: .skip size; \
> + .size __brk_##name, . - 1b; \
> .popsection

While I think about it before you write the patch properly, you ought to
have a .type in here too, seeing as the C side now gets one.

~Andrew