Re: 5.19-rc1 x86 build failure

[Josh Poimboeuf]

On Wed, Jun 08, 2022 at 09:24:25AM +0000, Andrew Cooper wrote:
> On 08/06/2022 01:59, Josh Poimboeuf wrote:
> > @@ -133,12 +125,16 @@ asmlinkage void __init x86_64_start_reservations(char *real_mode_data);
> >  
> >  #endif /* __i386__ */
> >  #endif /* _SETUP */
> > -#else
> > -#define RESERVE_BRK(name,sz)				\
> > -	.pushsection .brk_reservation,"aw",@nobits;	\
> > -.brk.name:						\
> > -1:	.skip sz;					\
> > -	.size .brk.name,.-1b;				\
> > +
> > +#else  /* __ASSEMBLY */
> > +
> > +#define RESERVE_BRK(name, size)				\
> > +	.pushsection .brk_reservation, "aw";		\
> > +__brk_##name:						\
> > +1:	.skip size;					\
> > +	.size __brk_##name, . - 1b;			\
> >  	.popsection
> 
> While I think about it before you write the patch properly, you ought to
> have a .type in here too, seeing as the C side now gets one.

Good point, I'll just use the SYM_DATA_{START,END} macros.

-- 
Josh